Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single redis connection per process #409

Merged

Conversation

mishaschwartz
Copy link
Contributor

In order to reduce the number of total redis connections used by the autotester:

  • use a single redis connection by each of the API (client) processes. This is declared as a global variable
  • use the same redis connection used by the rq job in each worker process
  • use a single redis connection in the installer script
  • use a single redis connection in the start_stop script

Note that in the API, two types of connection were previously required: one that decoded all responses and another that did not. In order to use a single connection, the code that assumed that responses are decoded are updated to handle decoding as needed.

@mishaschwartz mishaschwartz added this to the v2.2.3 milestone Oct 26, 2022
@david-yz-liu david-yz-liu merged commit 1bd8ca8 into MarkUsProject:master Oct 29, 2022
@mishaschwartz mishaschwartz deleted the single-redis-connection branch October 31, 2022 12:48
mishaschwartz added a commit to mishaschwartz/markus-autotesting that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants